Skip to content

feat: Adding github_enterprise_ip_allow_list_entry resource#2649

Merged
stevehipwell merged 35 commits intointegrations:mainfrom
ErikElkins:feat/enterprise-ip-allow-list
Apr 13, 2026
Merged

feat: Adding github_enterprise_ip_allow_list_entry resource#2649
stevehipwell merged 35 commits intointegrations:mainfrom
ErikElkins:feat/enterprise-ip-allow-list

Conversation

@ErikElkins
Copy link
Copy Markdown
Contributor

@ErikElkins ErikElkins commented May 2, 2025 •
edited
Loading

Resolves #2648

Before the change?

  • None

After the change?

  • Adding the github_enterprise_ip_allow_list_entry resource.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active May 2, 2025
@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
@ErikElkins ErikElkins changed the title Adding github_enterprise_ip_allow_list_entry resource feat: Adding github_enterprise_ip_allow_list_entry resource Oct 25, 2025
@deiga deiga mentioned this pull request Nov 4, 2025
Open
1 task
@github-actions github-actions bot added the Type: Feature New feature or request label Jan 13, 2026
nickfloyd
nickfloyd previously approved these changes Jan 13, 2026
View reviewed changes
@nickfloyd nickfloyd added this to the v6.10.0 Release milestone Jan 13, 2026
@nickfloyd
Copy link
Copy Markdown
Contributor

nickfloyd commented Jan 13, 2026

@ErikElkins Apologies for the delay on getting to this PR. Would you be willing to fix the lint issue? Thank you!

stevehipwell
stevehipwell requested changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a REST API for this functionality?

@github-project-automation github-project-automation bot moved this from 👀 In review to 🏗 In progress in 🧰 Octokit Active Jan 13, 2026
@gateixeira gateixeira mentioned this pull request Jan 13, 2026
Closed
4 tasks
@ErikElkins
Copy link
Copy Markdown
Contributor Author

ErikElkins commented Jan 13, 2026

Yep! Let me jump in here.

@ErikElkins @stevehipwell
Update github/resource_github_enterprise_ip_allow_list_entry.go
83a0055 
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
@ErikElkins @stevehipwell
Update github/resource_github_enterprise_ip_allow_list_entry.go
c3735ac 
Co-authored-by: Steve Hipwell <steve.hipwell@gmail.com>
@ErikElkins
Copy link
Copy Markdown
Contributor Author

ErikElkins commented Jan 13, 2026 •
edited
Loading

Oh, i see the other PR. Should we just close this? EDIT: NEVERMIND

@ErikElkins
Copy link
Copy Markdown
Contributor Author

ErikElkins commented Jan 13, 2026

Is there a REST API for this functionality?

Doesn't look like they've added it since I opened the PR.

gateixeira
gateixeira suggested changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gateixeira gateixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ErikElkins 👋

I was updating your PR to have the lint fixed and realized that the acceptance tests seem to also not pass. Can you please update the PR with the following? Feel free to validate on your end.

ErikElkins and others added 3 commits January 13, 2026 14:52
@ErikElkins @gateixeira
Update github/resource_github_enterprise_ip_allow_list_entry.go
833f3f1 
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
@ErikElkins @gateixeira
Update github/resource_github_enterprise_ip_allow_list_entry_test.go
60c686b 
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
@ErikElkins @gateixeira
Update github/resource_github_enterprise_ip_allow_list_entry_test.go
f667dcc 
Co-authored-by: gateixeira <4645845+gateixeira@users.noreply.github.com>
gateixeira
gateixeira approved these changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gateixeira gateixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErikElkins thanks for the changes!

stevehipwell
stevehipwell previously approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Copy Markdown
Collaborator

stevehipwell commented Feb 24, 2026

@deiga are you happy with this now? If so could you please approve (or clear your requested changes)?

deiga
deiga requested changes Feb 24, 2026
View reviewed changes
@deiga deiga requested a review from stevehipwell March 5, 2026 22:50
@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Mar 24, 2026

@ErikElkins Would you be available to rebase and test this again? :)

@ErikElkins
Copy link
Copy Markdown
Contributor Author

ErikElkins commented Mar 24, 2026

@ErikElkins Would you be available to rebase and test this again? :)

Merged and tested, looks good!

stevehipwell
stevehipwell previously approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell
Copy link
Copy Markdown
Collaborator

stevehipwell commented Apr 1, 2026

@robert-crandall could you please review/approve this?

robert-crandall
robert-crandall previously approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown

@robert-crandall robert-crandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good. It looks like it's failing CI due to lint errors. Once those are fixed, this is good to go.

@ErikElkins ErikElkins dismissed stale reviews from robert-crandall and stevehipwell via 1a2c79e April 2, 2026 19:16
@ErikElkins
Copy link
Copy Markdown
Contributor Author

ErikElkins commented Apr 2, 2026

This PR looks good. It looks like it's failing CI due to lint errors. Once those are fixed, this is good to go.

Done!

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Apr 2, 2026

@stevehipwell @robert-crandall please review again ☺️

@LornaJoyce
Copy link
Copy Markdown

LornaJoyce commented Apr 13, 2026

Hello, Could this get reviewed please?

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Apr 13, 2026

@ErikElkins could you please rebase, so that @stevehipwell can do final review?

@ErikElkins
Copy link
Copy Markdown
Contributor Author

ErikElkins commented Apr 13, 2026

@ErikElkins could you please rebase, so that @stevehipwell can do final review?

Done!

stevehipwell
stevehipwell approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell enabled auto-merge (squash) April 13, 2026 19:08
@stevehipwell stevehipwell merged commit 866a673 into integrations:main Apr 13, 2026
10 of 13 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Apr 13, 2026
@ErikElkins ErikElkins deleted the feat/enterprise-ip-allow-list branch April 13, 2026 19:45
@ErikElkins
Copy link
Copy Markdown
Contributor Author

ErikElkins commented Apr 13, 2026

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deiga deiga deiga approved these changes

@stevehipwell stevehipwell stevehipwell approved these changes

@robert-crandall robert-crandall robert-crandall approved these changes

+2 more reviewers

@gateixeira gateixeira gateixeira approved these changes

@nickfloyd nickfloyd nickfloyd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

github_enterprise New resource Type: Feature New feature or request

Projects

None yet

Milestone

v6.12.0 Release

Development

Successfully merging this pull request may close these issues.

[FEAT]: IP Allow Lists for enterprises and organizations

8 participants

@ErikElkins @nickfloyd @deiga @stevehipwell @LornaJoyce @gateixeira @robert-crandall @octokitbot